Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove an obsolete style declaration of .mx_ReplyChain_show #8743

Merged
merged 7 commits into from
Jun 13, 2022
Merged

Remove an obsolete style declaration of .mx_ReplyChain_show #8743

merged 7 commits into from
Jun 13, 2022

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 2, 2022

Before After
before after

It was added with https://github.com/matrix-org/matrix-react-sdk/pull/6291/files#diff-11808ff6468e6efa5982f414119fcc8a3a3eea4090b1a4ebda8ed6eae732418aR163 (#6291). It has not been effective for unknown period, and since the layout of the area has changed from flexbox/grid for order property, it should be able to be safely removed.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com


This change is marked as an internal change (Task), so will not be included in the changelog.

It was added with https://github.com/matrix-org/matrix-react-sdk/pull/6291/files#diff-11808ff6468e6efa5982f414119fcc8a3a3eea4090b1a4ebda8ed6eae732418aR163

It has not been effective for unknown period, and since the layout of the area has changed, it should be able to be safely removed.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 2, 2022
@luixxiul luixxiul marked this pull request as ready for review June 2, 2022 06:43
@luixxiul luixxiul requested a review from a team as a code owner June 2, 2022 06:43
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Tested, works 👍

@luixxiul
Copy link
Contributor Author

luixxiul commented Jun 2, 2022

Removing it also makes it possible to fix the large pill (with a long display name) alignment 😃

@MadLittleMods MadLittleMods added the Z-Community-PR Issue is solved by a community member's PR label Jun 2, 2022
@weeman1337
Copy link
Contributor

@luixxiul can you merge develop into this?

@luixxiul
Copy link
Contributor Author

@weeman1337 Done!

@weeman1337 weeman1337 merged commit 68ce7bf into matrix-org:develop Jun 13, 2022
@luixxiul luixxiul deleted the ReplyChain branch June 13, 2022 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants