This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Align NetworkDropdown component with new design #8380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
added
the
T-Task
Codecov Report
@@ Coverage Diff @@
## develop #8380 +/- ##
========================================
Coverage 30.40% 30.41%
========================================
Files 889 889
Lines 50507 50506 -1
Branches 12861 12861
========================================
+ Hits 15359 15360 +1
+ Misses 35148 35146 -2
|
kerryarchibald
approved these changes
Apr 21, 2022
niquewoodhouse
suggested changes
Apr 22, 2022
There was a problem hiding this comment.
Minor changes requested. First off, love that you're aligning the components!
I just want to explain the design a little first for context. I noticed the Threads beta has a drop down design and I wanted to mimic the styling, so its consistent with latest dropdowns. I think between my Figma and the actual threads dropdown we have some things to align, I've updated the design here to be more like Threads dropdown (image below)
Default style
- Add
Show:to start of content - Edit border and border radius
- Edit size of chevron to match Threads chevron
Hover style
- Edit border radius
Dropdown style
- Use border and box-shadow style of Threads dropdown
|
Closing as #8707 took over this piece |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to element-hq/element-web#21354
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8380--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.