Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Prevent infinite loops by dropping the input instead of crashing browser #7632

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 26, 2022

Follow up for #7629 to more generally prevent these types of issues


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://61f11608afa7316bdf0ebc57--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 26, 2022
@t3chguy t3chguy requested a review from a team as a code owner January 26, 2022 09:32
@t3chguy t3chguy force-pushed the t3chguy/fix/fix-release-blocker-plz branch from f3a00c7 to c8a4a68 Compare January 26, 2022 09:32
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea 👍

@t3chguy t3chguy changed the title Fix issue with the new composer EmojiPart which caused infinite loops Prevent infinite loops by dropping the input instead of crashing browser Jan 26, 2022
@t3chguy t3chguy merged commit 056c7c8 into develop Jan 26, 2022
@t3chguy t3chguy deleted the t3chguy/fix/fix-release-blocker-plz branch January 26, 2022 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants