Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Ignore unreads in low priority rooms in the space panel #6518

Merged
merged 6 commits into from
Aug 19, 2022
Merged

Ignore unreads in low priority rooms in the space panel #6518

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7e8b68
Ignore unreads in low priority rooms
SimonBrandner Jul 30, 2021
5769307
Get tags from the RoomListStore
SimonBrandner Jul 30, 2021
0a4700d
I don't know why I did that - roomTags is a string array
SimonBrandner Aug 5, 2021
c91334f
Merge remote-tracking branch 'upstream/develop' into feature/ignore-l…
SimonBrandner Aug 5, 2021
62af85d
Merge branch 'feature/ignore-low-prio-unreads' of https://github.com/…
SimonBrandner Aug 5, 2021
c6aa86e
Merge branch 'develop' into feature/ignore-low-prio-unreads
SimonBrandner Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/stores/notifications/SpaceNotificationState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import { arrayDiff } from "../../utils/arrays";
import { RoomNotificationState } from "./RoomNotificationState";
import { NOTIFICATION_STATE_UPDATE, NotificationState } from "./NotificationState";
import { FetchRoomFn } from "./ListNotificationState";
import { DefaultTagID } from "../room-list/models";
import RoomListStore from "../room-list/RoomListStore";

export class SpaceNotificationState extends NotificationState {
public rooms: Room[] = []; // exposed only for tests
Expand Down Expand Up @@ -74,7 +76,15 @@ export class SpaceNotificationState extends NotificationState {

this._count = 0;
this._color = NotificationColor.None;
for (const state of Object.values(this.states)) {
for (const [roomId, state] of Object.entries(this.states)) {
const roomTags = RoomListStore.instance.getTagsForRoom(this.rooms.find(r => r.roomId === roomId));

// We ignore unreads in LowPriority rooms, see https://github.com/vector-im/element-web/issues/16836
if (
roomTags.includes(DefaultTagID.LowPriority) &&
state.color === NotificationColor.Bold
) continue;

this._count += state.count;
this._color = Math.max(this.color, state.color);
}
Expand All @@ -83,4 +93,3 @@ export class SpaceNotificationState extends NotificationState {
this.emitIfUpdated(snapshot);
}
}