Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add view source button on error boundary for messages #5794

Conversation

panoschal
Copy link
Contributor

Fixes element-hq/element-web#15409

We could not want this, though, because I suppose errors will not happen at all, and you can use the console or the logs to debug the error.

I added a second link here. We could also do it with a context menu like on normal messages.
image

Signed-off-by: Panagiotis Chalimourdas panagiotis4531@gmail.com

@t3chguy t3chguy requested a review from a team March 25, 2021 15:39
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, though design will probably want to take a look too (iirc this was designed as shown)

src/components/views/messages/TileErrorBoundary.js Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from a team March 26, 2021 01:06
@nadonomy nadonomy self-assigned this Oct 19, 2021
@turt2live
Copy link
Member

I completely forgot about this PR and ended up re-implementing it myself, sorry. #7537 does the same thing but only when the developer mode flag is set (introduced after this PR was opened), thus making it not require design approval.

Thank you for the contribution, and apologies for forgetting about it 😬

@turt2live turt2live closed this Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to "View Source" on broken messages
3 participants