Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fall back to default avatar in RR when member isn't loaded yet #2204

Merged
merged 3 commits into from
Oct 10, 2018

Conversation

bwindels
Copy link
Contributor

As opposed to not rendering it at all, which makes all the RR pop in when the members are loaded, as reported in linked bug.

Fixes element-hq/element-web#7260

@bwindels bwindels requested a review from a team October 10, 2018 14:19
@bwindels
Copy link
Contributor Author

Thanks. Getting an error in Pills I want to look into before merging this:

Warning: Failed prop type: The prop `name` is marked as required in `BaseAvatar`, but its value is `undefined`.
    in BaseAvatar (created by MemberAvatar)
    in MemberAvatar (created by Pill)
    in a (created by Pill)
    in Pill

@bwindels
Copy link
Contributor Author

Can't repro it now, and should not throw in any case, so merging.

@bwindels bwindels merged commit dfb4c59 into develop Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants