Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Slate fixes #2066

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Slate fixes #2066

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7859fe
add heuristic to compare documents to prevent autocomplete flicker
t3chguy Jul 16, 2018
bdbc2cb
disable spellCheck when the placeholder is shown because "unencrypted"
t3chguy Jul 16, 2018
3000099
add additional checks for hiding autocomplete to prevent `text` calcu…
t3chguy Jul 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/views/rooms/MessageComposerInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,8 +498,12 @@ export default class MessageComposerInput extends React.Component {
}
}

// when selection changes hide the autocomplete
if (!rangeEquals(this.state.editorState.selection, editorState.selection)) {
// when in autocomplete mode and selection changes hide the autocomplete.
// Selection changes when we enter text so use a heuristic to compare documents without doing it recursively
if (this.autocomplete.state.completionList.length >= 0 && !this.autocomplete.state.hide &&
this.state.editorState.document.text !== editorState.document.text &&
!rangeEquals(this.state.editorState.selection, editorState.selection))
{
this.autocomplete.hide();
}

Expand Down Expand Up @@ -1541,7 +1545,8 @@ export default class MessageComposerInput extends React.Component {
onFocus={this.onFocus}
renderNode={this.renderNode}
renderMark={this.renderMark}
spellCheck={true}
// disable spell check for the placeholder because browsers don't like "unencrypted"
spellCheck={!this.state.editorState.document.isEmpty}
/>
</div>
</div>
Expand Down