This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement always-on-screen capability for widgets #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always-on-screen widgets now appear in the top-left where the call preview normally is if you're not in the room that they're in. Fixes element-hq/element-web#7007 Based off #2053
bwindels
approved these changes
Jul 13, 2018
| this.widgetMessaging.getCapabilities().then((requestedCapabilities) => { | ||
| console.log(`Widget ${this.props.id} requested capabilities:`, requestedCapabilities); | ||
| _setupWidgetMessaging() { | ||
| // FIXME: There's probably no reason to do this here: it should probably be done entirely |
bwindels
suggested changes
Jul 13, 2018
bwindels
approved these changes
Jul 16, 2018
|
conflicts in |
…llows_you_between_rooms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per matrix-org/matrix-doc#1354
This is whitelisted to only jitsi widgets for now as per comment,
mostly because any widget that we may make always-on-screen we need
to preemptively put in a PersistedElement container, which is
unnecessary for any other widget.
Apologies that this does a bunch of refactoring which could have
been split out separately: I only discovered what needed to be
refactored in the process of doing this.
Fixes element-hq/element-web#6984