-
-
Notifications
You must be signed in to change notification settings - Fork 834
Conversation
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Using /tint without a second color means the secondary_color is null/falsey. Previously, the code didn't treat it as optional. Signed-off-by: Travis Ralston <travpc@gmail.com>
this looks awesome! but shouldn't the default room colour picker be in UserSettings rather than RoomSettings, given it impacts the whole app rather than just that specific room? |
The default room color is per-room, to implement element-hq/element-web#738 ("let room admins set default room color"). It's backed by a state event in the room, and the user's room account data will override the state event's choices. Although this PR could be extended to add a 3rd color picker to UserSettings to have blanket defaults for all rooms. Is that something that would be wanted? |
aaaaah, i see. hmm. i wonder how much we really want room admins setting their own weird white-on-white style colour schemes for rooms... (and yes, i know i asked for it in the first place). I also wonder if this should be implemented using generic granular settings (i.e. the ability to specify settings arbitrarily per-user, per-room, globally - also useful for stuff like configuring hiding URL previews, join/parts and other cosmetics) |
It should be fine if room admins want to do that, as users can always override their choice. The room admin may also find themselves with an angry crowd of people or an empty room - which might be enough of a deterrent to going outside the color schemes Riot lets you define. Granular settings sounds like something @t3chguy has promised for quite a while now :p |
Granular Settings are still on the horizon (distant distant horizon) |
as for notes on Granular Settings I will try to recite part of a conversation between Matthew, Toml and I, Per-room per-device Per device is the ordering of the possible sources of truth in Granular Settings as far as I am aware as for whether I am okay with it, of course |
I'm blocking this on #1516 (Granular Settings). |
Closing this for now - it requires relatively drastic changes to work with granular settings and I'm completely out of spare time. |
Required PRs / Related issues
What it looks like
Note: The red/white tint at the end was part of a test. It's not actually part of the PR.