This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add sign out button to settings profile section #12666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
added
the
T-Enhancement
dbkr
force-pushed
the
dbkr/sign_out_button
branch
from
ab4d2ae
to
3e30430
Compare
And move the logic for displaying the dialog out of the user menu to somewhere it can be re-used. Also close any open dialog on logout, because otherwise, well... you can guess.
dbkr
force-pushed
the
dbkr/sign_out_button
branch
from
3f258ef
to
5f46ba0
Compare
t3chguy
reviewed
Jul 4, 2024
t3chguy
reviewed
Jul 4, 2024
richvdh
reviewed
Jul 8, 2024
src/Modal.tsx
Outdated
Comment on lines
118
to
129
| public constructor() { | ||
| super(); | ||
|
|
||
| // We never unregister this: it's a singleton. An instance could be instantiated, in theory... | ||
| defaultDispatcher.register(this.onAction); | ||
| } | ||
|
|
||
| private onAction = (payload: ActionPayload): void => { | ||
| if (payload.action === "logout") { | ||
| this.forceCloseAllModals(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
this feels like something that should be in a separate PR, tbh.
src/Modal.tsx
Outdated
| public constructor() { | ||
| super(); | ||
|
|
||
| // We never unregister this: it's a singleton. An instance could be instantiated, in theory... |
There was a problem hiding this comment.
An instance could be instantiated, in theory...
Don't quite get this. So we should deregister the listener?
There was a problem hiding this comment.
Updated this comment in the split out PR so hopefully its clearer.
| @@ -219,11 +243,12 @@ const UserProfileSettings: React.FC<UserProfileSettingsProps> = ({ | |||
| </Alert> | |||
| )} | |||
| {userIdentifier && <UsernameBox username={userIdentifier} />} | |||
| {externalAccountManagementUrl && ( | |||
| <div className="mx_UserProfileSettings_profile_buttons"> | |||
| <Flex gap="var(--cpd-space-4x)" className="mx_UserProfileSettings_profile_buttons"> | |||
There was a problem hiding this comment.
do we really want this sort of inline CSS? Shouldn't the gap be on the CSS class?
There was a problem hiding this comment.
I would really have thought so, yeah, but this seems to be how the Flex component is used, and that's what was suggested.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Close any open modals on logout Split out from #12666 * Add test
|
Split out PR also has a test :) |
t3chguy
approved these changes
Jul 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And move the logic for displaying the dialog out of the user menu to somewhere it can be re-used.
Also close any open dialog on logout, because otherwise, well... you can guess.
Checklist
public/exportedsymbols have accurate TSDoc documentation.