Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix decryption failure bar covering the timeline #10360

Merged
merged 24 commits into from
Mar 30, 2023
Merged

Fix decryption failure bar covering the timeline #10360

merged 24 commits into from
Mar 30, 2023

Commits on Mar 13, 2023

  1. Use grid layout instead

    - BEM naming style
    - Increase block gap from 4px to 8px
    - Use flexbox inside 'header' grid-area to let the buttons wrapped
    - Use variables
    - Remove 4px gap when one of the buttons is not rendered
    - Change 'body' to 'message'
    - Set 'align-self: start' to the icon and spinner
    
    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d2d9a6a View commit details
    Browse the repository at this point in the history
  2. Unset height of spinner

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    8640784 View commit details
    Browse the repository at this point in the history
  3. Break lines at newline characters with white-space: pre-line

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2758b15 View commit details
    Browse the repository at this point in the history
  4. Edit tests to check decryption failure bars on narrow timeline

    - checkTimelineNarrow() looks for buttons by default
    - Test indicator as well
    
    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    cc671b1 View commit details
    Browse the repository at this point in the history
  5. Remove a line

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6d7b8c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Edit the test to have it check mx_EventTile_last only inside mx_RoomV…

    …iew_body
    
    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    2a343d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Fix double underscores

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    45572ff View commit details
    Browse the repository at this point in the history
  2. Fix double underscores - pcss

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    981b601 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Configuration menu
    Copy the full SHA
    8b69e62 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Iterate - buttons at the bottom

    - Set common spacing to buttons with variables
    - Remove line breaks, yarn run i18n
    - Set data-testid for headlines and buttons in case the tested strings would be displayed elsewhere simultaneously
    
    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    eb6d902 View commit details
    Browse the repository at this point in the history
  2. Check waiting headline as well

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    228c195 View commit details
    Browse the repository at this point in the history
  3. Increase spacing between the message and the buttons

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    06f9dd9 View commit details
    Browse the repository at this point in the history
  4. lint

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    d1e272d View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Increase block gap between wrapped buttons for clickability

    Apply 8px between wrapped buttons
    
    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    626b808 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69281b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Configuration menu
    Copy the full SHA
    58a023d View commit details
    Browse the repository at this point in the history
  2. Revert bottom margin of buttons which are not expected to be wrapped

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    af1177b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Check visibility instead of existence

    This commit removes data-testid from headlines and data-testid-button and checks whether the elements are really visible, not overflowing the viewport.
    
    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    04ad0a8 View commit details
    Browse the repository at this point in the history
  2. Remove redundant gap between 'mx_DecryptionFailureBar_start' and the …

    …bottom edge
    
    This commit adds '.mx_DecryptionFailureBar--withEnd' class name to have it applied to the bar only if it has button(s). This way the bar is rendered with a flexbox and the row-gap declaration is respected only if there is a 'mx_DecryptionFailureBar--withEnd' element. The element  currently includes the button(s) only.
    
    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    02b4249 View commit details
    Browse the repository at this point in the history
  3. lint - prettier

    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    02afe55 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bb399ce View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Have Percy take a snapshot of the bar loading spinner before checkTim…

    …elineNarrow()
    
    The loading spinner is likely to disappear while checking the bar on the narrow timeline.
    
    Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
    luixxiul committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    ab39b65 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Configuration menu
    Copy the full SHA
    779e74b View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Configuration menu
    Copy the full SHA
    917a6a6 View commit details
    Browse the repository at this point in the history