This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Gitter sunsetting: Use findPredecessor in EventTileFactory #10075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjanne
added
the
T-Task
justjanne
force-pushed
the
justjanne/task/eventtilefactory-dynamic-predecessor
branch
from
0c5b766
to
1f0dce7
Compare
andybalaam
approved these changes
Feb 3, 2023
| @@ -250,7 +250,7 @@ describe("Timeline", () => { | |||
| cy.contains(".mx_RoomView_body .mx_EventTile[data-scroll-tokens]", "MessageEdit").should("exist"); | |||
|
|
|||
| // Click top left of the event toggle, which should not be covered by MessageActionBar's safe area | |||
| cy.get(".mx_EventTile .mx_ViewSourceEvent") | |||
| cy.get(".mx_EventTile:not(:first-child) .mx_ViewSourceEvent") | |||
There was a problem hiding this comment.
A comment here to explain this might be helpful - I assume it's because of "show hidden events" as we discussed?
justjanne
deleted the
justjanne/task/eventtilefactory-dynamic-predecessor
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Task
Fixes: element-hq/element-web#24327
After this, rooms with no predecessor in the create event can still show a RoomPredecessor tile, and it allows jumping back to the old room.
This change is marked as an internal change (Task), so will not be included in the changelog.