Passphrase Support for e2e backups #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Nov 21, 2018
src/client.js
Outdated
| * @param {string} password Passphrase string that can be entered by the user | ||
| * when restoring the backup as an alternative to entering the recovery key. | ||
| * Optional. | ||
| * | ||
| * @returns {object} Object that can be passed to createKeyBackupVersion and |
There was a problem hiding this comment.
this now returns a promise, not an object.
There was a problem hiding this comment.
Hmm, I was assuming the promise was implicit for async functions, but the convention seem to be to put it explicitly.
| limitations under the License. | ||
| */ | ||
|
|
||
| export function randomString(len) { |
There was a problem hiding this comment.
fwiw there's libraries for this if we want to avoid maintaining this sort of thing. https://www.npmjs.com/package/random-string for example
This was referenced Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements matrix-org/matrix-spec-proposals#1703