Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention deno support in the README #3417

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented May 28, 2023

Type: enhancement

It seems to work fine, and I have a demo bot with it https://github.com/sigmaSd/deno-matrix-bot


Here's what your changelog entry will look like:

✨ Features

  • mention deno support in the README (#3417). Contributed by @sigmaSd.

It seems to work fine, and I have a demo bot with it https://github.com/sigmaSd/deno-matrix-bot
@sigmaSd sigmaSd requested a review from a team as a code owner May 28, 2023 12:07
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 28, 2023
@sigmaSd
Copy link
Contributor Author

sigmaSd commented May 28, 2023

Signed-off-by: sigmasd

@sigmaSd sigmaSd changed the title mention deno support in the README Type: enhancement mention deno support in the README May 28, 2023
@sigmaSd sigmaSd changed the title Type: enhancement mention deno support in the README mention deno support in the README May 28, 2023
@florianduros
Copy link
Contributor

florianduros commented May 31, 2023

Hello !
First of all, thank you for contribution!

Currently we are not officially supporting deno so I'm concerned to add documentation about it.

@sigmaSd
Copy link
Contributor Author

sigmaSd commented May 31, 2023

Hi that's reasonable, maybe instead of this we can add one line that says you can use this sdk with deno (using npm compat) but it's not officially supported
its working great so far in my couple of days testing

@florianduros
Copy link
Contributor

Imo it seems to be a good compromise :)

@sigmaSd
Copy link
Contributor Author

sigmaSd commented May 31, 2023

I updated the wording 56240fa

Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@florianduros florianduros added this pull request to the merge queue Jun 1, 2023
Merged via the queue into matrix-org:develop with commit feb424b Jun 1, 2023
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Dec 13, 2023
* Ensure we do not add relations to the wrong timeline ([\matrix-org#3427](matrix-org#3427)). Fixes element-hq/element-web#25450 and element-hq/element-web#25494.
* Deprecate `QrCodeEvent`, `SasEvent` and `VerificationEvent` ([\matrix-org#3386](matrix-org#3386)).
* Move crypto classes into a separate namespace ([\matrix-org#3385](matrix-org#3385)).
* Mention deno support in the README ([\matrix-org#3417](matrix-org#3417)). Contributed by @sigmaSd.
* Mark room version 10 as safe ([\matrix-org#3425](matrix-org#3425)).
* Prioritise entirely supported flows for UIA ([\matrix-org#3402](matrix-org#3402)).
* Add methods to terminate idb worker ([\matrix-org#3362](matrix-org#3362)).
* Total summary count ([\matrix-org#3351](matrix-org#3351)). Contributed by @toger5.
* Audio concealment ([\matrix-org#3349](matrix-org#3349)). Contributed by @toger5.
* Correctly accumulate sync summaries. ([\matrix-org#3366](matrix-org#3366)). Fixes element-hq/element-web#23345.
* Keep measuring a call feed's volume after a stream replacement ([\matrix-org#3361](matrix-org#3361)). Fixes element-hq/element-call#1051.
* Element-R: Avoid uploading a new fallback key at every `/sync` ([\matrix-org#3338](matrix-org#3338)). Fixes element-hq/element-web#25215.
* Accumulate receipts for the main thread and unthreaded separately ([\matrix-org#3339](matrix-org#3339)). Fixes element-hq/element-web#24629.
* Remove spec non-compliant extended glob format ([\matrix-org#3423](matrix-org#3423)). Fixes element-hq/element-web#25474.
* Fix bug where original event was inserted into timeline instead of the edit event ([\matrix-org#3398](matrix-org#3398)). Contributed by @andybalaam.
* Only add a local receipt if it's after an existing receipt ([\matrix-org#3399](matrix-org#3399)). Contributed by @andybalaam.
* Attempt a potential workaround for stuck notifs ([\matrix-org#3384](matrix-org#3384)). Fixes element-hq/element-web#25406. Contributed by @andybalaam.
* Fix verification bug with `pendingEventOrdering: "chronological"` ([\matrix-org#3382](matrix-org#3382)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants