Fix call upgrades #2024
Merged
Fix call upgrades #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live
requested changes
Nov 19, 2021
Should have thought of that... I've updated the description |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Dec 7, 2021
* Remove support for `ArrayBuffer` in unstable MSC3089 `createFile()` and `createNewVersion()` and instead use same content types as handled by `MatrixClient.uploadContent()`. This enables support for Node.js. ([\matrix-org#2014](matrix-org#2014)). * Support for password-based backup on Node.js ([\matrix-org#2021](matrix-org#2021)). * Add optional force parameter when ensuring Olm sessions ([\matrix-org#2027](matrix-org#2027)). * Fix call upgrades ([\matrix-org#2024](matrix-org#2024)). Contributed by @SimonBrandner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: defect
Due to
CallFeeds mute state being set to muted based on their tracks at the time of their creation we can get stuck with them being muted. This happens because the code that determines if aCallFeedis muted looks like this:This means that if
videoMutedistruethe feed will be muted no matter the present tracks. ThevideoMutedproperty should only work as an override based on the remoteSPDStreamMetadataHere's what your changelog entry will look like:
🐛 Bug Fixes