Add some logging around sync for stuck message debugging #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For matrix-org/synapse#7206 Intended to be removed (or possibly converted into a proper off-by-default setting) once the issue concludes. There's a bunch of null checking through defaults here because this is a very critical part of the whole stack. We default to writing errors to the console, but do not break the app for failing to log info about the sync. This may have adverse affects on performance for large accounts - use `localStorage.setItem("mx_skip_sync_logging", "true")` to disable the worst parts.
For tests this was adding 25 minutes before giving up.
jryans
approved these changes
Apr 3, 2020
jryans
reviewed
Apr 3, 2020
jryans
requested changes
Apr 3, 2020
|
Looks like we're just going to have to give up on this and debug somehow else (like having devtools open to consume all the RAM) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For matrix-org/synapse#7206
Reviewer: if this looks okay, please merge it so the backend team can test with it ASAP.
Intended to be removed (or possibly converted into a proper off-by-default setting) once the issue concludes.
There's a bunch of null checking through defaults here because this is a very critical part of the whole stack. We default to writing errors to the console, but do not break the app for failing to log info about the sync.
To enable, run
localStorage.setItem("mx_do_sync_logging", "true");in the JS console