-
-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make screen sharing works on Chrome using getDisplayMedia() #1276
Conversation
Signed-off-by: mjattiot <mjattiot@opensense.fr>
Signed-off-by: mjattiot <mjattiot@opensense.fr>
0700388
to
e251589
Compare
MDN support info is apparently outdated, as it seems Safari 13 on desktop is supported as well. We should test in all 3 supported browsers as part of the review to be sure it does indeed work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks fine, and testing it feels non-trivial on all three browsers. https://caniuse.com/#search=getDisplayMedia also says Safari is not supported.
@jryans where are you seeing that it is supported? If it is in fact supported and all the sources are wrong, I'd be inclined to merge this and test it live instead of trying to test it ourselves. This is a low-traffic part of the repo and this is a relatively atomic change to back out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, my evidence for Safari was:
- A blog post about it seeming to work
- This detection page claiming it works when I checked in Safari
Anyway, as already mentioned, we don't support Safari for VoIP today, so there's no regression to worry about.
Screen sharing has never been working on recent versions of Chrome (fixes element-hq/element-web#6181).
This PR intends to use the new API getDisplayMedia() to make it works on all recent browsers : https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getDisplayMedia
Signed-off-by: Maxime Jattiot mjattiot@opensense.fr