This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
Replace GHMarkdownParser with CommonMark #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by a space. No need for this extra validation.
manuroe
reviewed
Feb 27, 2017
There was a problem hiding this comment.
I made few tests using riot-ios. It works very well except in one case: multi lines are rendered as a single line.
It may need some tweaks like the react-sdk needed to do (https://github.com/matrix-org/matrix-react-sdk/pull/711/files).
…be converted to br tags. Also adds a test case.
This was referenced Feb 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces with the GHMarkdownParser library with the cmark (CommonMark) library.
This also resolves #188.
signed-off-by: Avery Pierce aapierce0@gmail.com