Ensure encrypted events are not handled twice #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
commented
Oct 30, 2020
Half-Shot
commented
Oct 30, 2020
src/components/encryption.ts
Outdated
|
|
||
| // Delete the event from the pending list | ||
| this.eventsPendingSync.delete(event.event_id); | ||
| let index = this.eventsPendingAS.findIndex((e) => e.event_id === event.event_id); |
There was a problem hiding this comment.
It's possible we might get multiple sync events stored.
Half-Shot
commented
Oct 30, 2020
benparsons
suggested changes
Oct 30, 2020
src/components/encryption.ts
Outdated
| @@ -86,16 +86,18 @@ export class EncryptedEventBroker { | |||
| private onEphemeralEvent: ((event: EphemeralEvent) => void)|undefined, | |||
| private getIntent: (userId: string) => Intent | |||
| ) { | |||
| if (this.onEphemeralEvent) { | |||
| this.presenceCleanupInterval = setInterval(() => { | |||
| const ts = Date.now() - 30000; | |||
There was a problem hiding this comment.
30s wants to be a config var?
There was a problem hiding this comment.
We should make it a const but I don't think there is any value in it being a config value, it's just a cache lifetime.
src/components/encryption.ts
Outdated
| this.eventsPendingSync.delete(event.event_id); | ||
| let index = this.eventsPendingAS.findIndex((e) => e.event_id === event.event_id); | ||
| do { | ||
| this.eventsPendingAS.splice(index, 1); |
There was a problem hiding this comment.
Would all of this be possible with this.eventsPendingAS = this.eventsPendingAS.filter((e) => e.event_id !== event.event_id)?
There was a problem hiding this comment.
Yeah, I prefer that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266
This should address some problems with the encrypted event tracking