Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a function to set a user's custom displayname in a room #248

Merged
merged 3 commits into from
Oct 12, 2020
Merged

add a function to set a user's custom displayname in a room #248

merged 3 commits into from
Oct 12, 2020

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Oct 9, 2020

No description provided.

@uhoreg uhoreg mentioned this pull request Oct 9, 2020
Merged
Half-Shot
Half-Shot reviewed Oct 9, 2020
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts

src/components/intent.ts Outdated Show resolved Hide resolved
src/components/intent.ts Outdated Show resolved Hide resolved
@uhoreg uhoreg marked this pull request as ready for review October 9, 2020 20:40
@uhoreg uhoreg requested a review from Half-Shot October 9, 2020 20:40
Half-Shot
Half-Shot approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@Half-Shot Half-Shot merged commit a30ecd0 into develop Oct 12, 2020
@Half-Shot Half-Shot deleted the uhoreg/set_room_user_display_name branch May 2, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uhoreg @Half-Shot