Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Interaction triggers #54

Merged
merged 1 commit into from
Apr 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions schemas/Interaction.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@
{"const": "WebSpaceHomeCreateRoomButton", "description": "User clicked the new room button in the context menu on the space home in Element Web/Desktop." },
{"const": "WebSpaceContextMenuNewRoomItem", "description": "User clicked the new room button in the context menu of a space in Element Web/Desktop." },
{"const": "WebAddExistingToSpaceDialogCreateRoomButton", "description": "User clicked the create room button in the add existing room to space dialog in Element Web/Desktop." },
{"const": "WebHomeCreateChatButton", "description": "User clicked the create DM button in the home page of Element Web/Desktop." },
{"const": "WebRoomListRoomsSublistPlusMenuCreateChatItem", "description": "User clicked the create DM button in the + context menu of the rooms sublist in Element Web/Desktop." },
{"const": "WebRoomListHeaderPlusMenuCreateChatItem", "description": "User clicked the create DM button in the + context menu of the room list header in Element Web/Desktop." },
{"const": "WebSpaceContextMenuHomeItem", "description": "User clicked the home button in the context menu of a space in Element Web/Desktop." },
{"const": "WebHomeExploreRoomsButton", "description": "User clicked the explore rooms button in the home page of Element Web/Desktop." },
{"const": "WebLeftPanelExploreRoomsItem", "description": "User clicked the explore rooms button next to the search field at the top of the left panel in Element Web/Desktop." },
{"const": "WebSpaceContextMenuExploreRoomsItem", "description": "User clicked the explore rooms button in the context menu of a space in Element Web/Desktop." },
{"const": "WebRoomListHeaderPlusMenuExploreRoomsItem", "description": "User clicked the explore rooms button in the + context menu of the room list header in Element Web/Desktop." },
{"const": "WebRoomListRoomsSublistPlusMenuExploreRoomsItem", "description": "User clicked the explore rooms button in the + context menu of the rooms sublist in Element Web/Desktop." },
Expand Down
1,402 changes: 713 additions & 689 deletions types/html/index.html

Large diffs are not rendered by default.

30 changes: 30 additions & 0 deletions types/kotlin2/Interaction.kt
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,30 @@ data class Interaction(
*/
WebAddExistingToSpaceDialogCreateRoomButton,

/**
* User clicked the create DM button in the home page of Element
* Web/Desktop.
*/
WebHomeCreateChatButton,

/**
* User clicked the create room button in the home page of Element
* Web/Desktop.
*/
WebHomeCreateRoomButton,

/**
* User clicked the explore rooms button in the home page of Element
* Web/Desktop.
*/
WebHomeExploreRoomsButton,

/**
* User clicked the explore rooms button next to the search field at the
* top of the left panel in Element Web/Desktop.
*/
WebLeftPanelExploreRoomsItem,

/**
* User interacted with pin to sidebar checkboxes in the quick settings
* menu of Element Web/Desktop.
Expand Down Expand Up @@ -189,6 +207,12 @@ data class Interaction(
*/
WebRoomHeaderContextMenuSettingsItem,

/**
* User clicked the create DM button in the + context menu of the room
* list header in Element Web/Desktop.
*/
WebRoomListHeaderPlusMenuCreateChatItem,

/**
* User clicked the create room button in the + context menu of the room
* list header in Element Web/Desktop.
Expand Down Expand Up @@ -231,6 +255,12 @@ data class Interaction(
*/
WebRoomListRoomTileNotificationsMenu,

/**
* User clicked the create DM button in the + context menu of the rooms
* sublist in Element Web/Desktop.
*/
WebRoomListRoomsSublistPlusMenuCreateChatItem,

/**
* User clicked the create room button in the + context menu of the
* rooms sublist in Element Web/Desktop.
Expand Down
5 changes: 0 additions & 5 deletions types/kotlin2/JoinedRoom.kt
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,6 @@ data class JoinedRoom(
*/
Invite,

/**
* Room joined via space explore
*/
MobileExploreRooms,

/**
* Room joined via link
*/
Expand Down
10 changes: 10 additions & 0 deletions types/swift/Interaction.swift
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,14 @@ extension AnalyticsEvent {
case SpacePanelSwitchSpace
/// User clicked the create room button in the add existing room to space dialog in Element Web/Desktop.
case WebAddExistingToSpaceDialogCreateRoomButton
/// User clicked the create DM button in the home page of Element Web/Desktop.
case WebHomeCreateChatButton
/// User clicked the create room button in the home page of Element Web/Desktop.
case WebHomeCreateRoomButton
/// User clicked the explore rooms button in the home page of Element Web/Desktop.
case WebHomeExploreRoomsButton
/// User clicked the explore rooms button next to the search field at the top of the left panel in Element Web/Desktop.
case WebLeftPanelExploreRoomsItem
/// User interacted with pin to sidebar checkboxes in the quick settings menu of Element Web/Desktop.
case WebQuickSettingsPinToSidebarCheckbox
/// User interacted with the theme dropdown in the quick settings menu of Element Web/Desktop.
Expand Down Expand Up @@ -90,6 +96,8 @@ extension AnalyticsEvent {
case WebRoomHeaderContextMenuPeopleItem
/// User accessed room settings using the context menu on the header of a room in Element Web/Desktop.
case WebRoomHeaderContextMenuSettingsItem
/// User clicked the create DM button in the + context menu of the room list header in Element Web/Desktop.
case WebRoomListHeaderPlusMenuCreateChatItem
/// User clicked the create room button in the + context menu of the room list header in Element Web/Desktop.
case WebRoomListHeaderPlusMenuCreateRoomItem
/// User clicked the explore rooms button in the + context menu of the room list header in Element Web/Desktop.
Expand All @@ -104,6 +112,8 @@ extension AnalyticsEvent {
case WebRoomListRoomTileContextMenuSettingsItem
/// User accessed their room notification settings via the context menu on a room tile in the room list in Element Web/Desktop.
case WebRoomListRoomTileNotificationsMenu
/// User clicked the create DM button in the + context menu of the rooms sublist in Element Web/Desktop.
case WebRoomListRoomsSublistPlusMenuCreateChatItem
/// User clicked the create room button in the + context menu of the rooms sublist in Element Web/Desktop.
case WebRoomListRoomsSublistPlusMenuCreateRoomItem
/// User clicked the explore rooms button in the + context menu of the rooms sublist in Element Web/Desktop.
Expand Down
2 changes: 0 additions & 2 deletions types/swift/JoinedRoom.swift
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ extension AnalyticsEvent {
public enum Trigger: String {
/// Room joined via an invite.
case Invite
/// Room joined via space explore
case MobileExploreRooms
/// Room joined via link
case MobilePermalink
/// Room joined via a push/desktop notification.
Expand Down
5 changes: 5 additions & 0 deletions types/typescript/Interaction.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@ export interface Interaction {
| "WebSpaceHomeCreateRoomButton"
| "WebSpaceContextMenuNewRoomItem"
| "WebAddExistingToSpaceDialogCreateRoomButton"
| "WebHomeCreateChatButton"
| "WebRoomListRoomsSublistPlusMenuCreateChatItem"
| "WebRoomListHeaderPlusMenuCreateChatItem"
| "WebSpaceContextMenuHomeItem"
| "WebHomeExploreRoomsButton"
| "WebLeftPanelExploreRoomsItem"
| "WebSpaceContextMenuExploreRoomsItem"
| "WebRoomListHeaderPlusMenuExploreRoomsItem"
| "WebRoomListRoomsSublistPlusMenuExploreRoomsItem"
Expand Down
1 change: 0 additions & 1 deletion types/typescript/JoinedRoom.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ export interface JoinedRoom {
| "Timeline"
| "Notification"
| "MobilePermalink"
| "MobileExploreRooms"
) &
string;
/**
Expand Down