Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement room creation content #754

Merged
merged 5 commits into from
Jul 24, 2019
Merged

Implement room creation content #754

merged 5 commits into from
Jul 24, 2019

Conversation

Cnly
Copy link
Contributor

@Cnly Cnly commented Jul 22, 2019

Fixes #660.

Signed-off-by: Alex Chen minecnly@gmail.com

Pull Request Checklist

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off

@Cnly
Implement room creation content - fixes matrix-org#660
764b459 
Signed-off-by: Alex Chen <minecnly@gmail.com>
@Cnly Cnly requested a review from anoadragon453 July 22, 2019 09:13
anoadragon453
anoadragon453 suggested changes Jul 22, 2019
View reviewed changes
common/eventcontent.go Outdated Show resolved Hide resolved
Cnly and others added 3 commits July 22, 2019 22:12
@Cnly Cnly requested a review from anoadragon453 July 22, 2019 14:17
@Cnly
Remove duplicate comment
abc8d7f 
Signed-off-by: Alex Chen <minecnly@gmail.com>
@anoadragon453
Copy link
Member

Also fyi it looks like the creator field is going the way of the dodo: matrix-org/matrix-spec-proposals#2175

@Cnly
Copy link
Contributor Author

Cnly commented Jul 22, 2019

Thanks. no objections from the Dendrite perspective I think.

anoadragon453
anoadragon453 approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anoadragon453 anoadragon453 merged commit 604685c into matrix-org:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
C-Client-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement room creation content
2 participants
@Cnly @anoadragon453