Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model version for Potential class is modified #194

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

kenko911
Copy link
Contributor

Summary

The model version of the Potential class is changed from 1 to 2. This prevents the wrong loading of the model.

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

@kenko911 kenko911 requested a review from janosh November 17, 2023 19:07
@janosh
Copy link
Collaborator

janosh commented Nov 17, 2023

@kenko911 What do you need from me?

@kenko911
Copy link
Contributor Author

kenko911 commented Nov 17, 2023

Hi @janosh, thanks for reporting the error. I just changed the model version and I would like to know if it fixes the error you reported in #193😁?

@janosh
Copy link
Collaborator

janosh commented Nov 17, 2023

@shyuep already fixed the error in v0.9.0.

@shyuep
Copy link
Contributor

shyuep commented Nov 17, 2023

@janosh Yes it is fixed. But this is more for future-proofness. We want a proper versioning of model so that the cache invalidation works properly. It is not related to the tests in pymatgen/downstream codes.

@shyuep shyuep merged commit a7ae4a9 into materialsvirtuallab:main Nov 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants