Fix task type for NSCF line TaskDoc's #1127
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bug where TaskDoc.task_type is incorrectly determined for older NSCF line calcs
In TaskDocument, the
orig_inputs
are used to determine thetask_type
. The KPOINTS inorig_inputs
retain user-input labels, and the NSCF line check currently only looks for these being non-emptyIn TaskDoc, the task_type is determined from
calcs_reversed.0.input
, failing that,input
, and failing that,orig_inputs
. Bothcalcs_reversed.0.input
andinput
read KPOINTS from vasprun.xml, which may have labels removed (may have been an issue with older parsed tasks).