Fix TrajectoryObserver.to_ase_trajectory return type
#852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrushikesh-s
pushed a commit
to hrushikesh-s/atomate2
that referenced
this pull request
Jun 28, 2024
…ect#852) * fix TrajectoryObserver.to_ase_trajectory() return type to TrajectoryReader * more descriptive variable names * fix typo * fix clashing var rename * rename d->dct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrajectoryObserver.to_ase_trajectorydoes not returnase.io.Trajectory(as prev annotated) which (confusingly) is a function but anase.io.trajectory.TrajectoryReaderinstance