Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema update > Update plot example LOBSTER workflow #682

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Jan 17, 2024

Recent schema update lead to change in outputs of Lobster task document as new models were added

Closes #680

Todo

  • Test the codes from example

Recent schema update lead to change in outputs of Lobster task document as new models were added
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4869a35) 76.25% compared to head (0c213c1) 76.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   76.25%   76.09%   -0.16%     
==========================================
  Files          87       87              
  Lines        7150     7150              
  Branches     1057     1057              
==========================================
- Hits         5452     5441      -11     
- Misses       1374     1386      +12     
+ Partials      324      323       -1     

see 1 file with indirect coverage changes

@naik-aakash naik-aakash changed the title [WIP] Schema update > Update plot example LOBSTER workflow Schema update > Update plot example LOBSTER workflow Jan 17, 2024
@naik-aakash
Copy link
Contributor Author

Hi @utf , this PR could be merged

@utf
Copy link
Member

utf commented Jan 17, 2024

Thanks!

@utf utf merged commit 5ec73f7 into materialsproject:main Jan 17, 2024
7 checks passed
@utf utf added the enhancement Improvements to existing features label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: KeyError: 'efermi' in lobster example from documentation
2 participants