Resolve bandstructure datastore bug #605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #584.
I added "bandstructure" to the list of object names that should be saved in the datastore. I think it is related to how emmet saves the bandstructures:
https://github.com/materialsproject/emmet/blob/08f143833ac6ba5732abadb7beee9e424d0220cf/emmet-core/emmet/core/vasp/calculation.py#L49
For DOS, I assume it works by accident.