Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox theme not usable due to lost reference to tokens.$md-comp-checkbox-supported-tokens #5651

Closed
randymorman-nisc opened this issue Jun 19, 2024 · 1 comment · Fixed by #5653 or #5634 · May be fixed by VandeurenGlenn/Cadle#26, X-oss-byte/pigweed#73 or VandeurenGlenn/Cadle#28
Assignees

Comments

@randymorman-nisc
Copy link

randymorman-nisc commented Jun 19, 2024

What is affected?

Theming

Description

The reference of tokens.$md-comp-checkbox-supported-tokens was changed to $md-comp-checkbox-supported-tokens . This is preventing the compiling of the theme.

28 │   $supported-tokens: $md-comp-checkbox-supported-tokens;
   │                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
  node_modules/@material/web/checkbox/internal/_checkbox.scss 28:22  theme()
  src/styles.scss 6:3                                                create-checkbox-theme()
  src/styles.scss 10:3                                               root stylesheet [plugin angular-sass]

    angular:styles/global:styles:1:8:
      1 │ @import 'src/styles.scss';

Reproduction

https://stackblitz.com/edit/stackblitz-starters-qcknxm?file=src%2Fstyles.scss

@use '@material/web/tokens/index' as tokens;
@use '@material/web/checkbox/checkbox' as checkbox;
@use 'sass:map';

@mixin create-checkbox-theme() {
  @include checkbox.theme(tokens.md-comp-checkbox-values());
}

Workaround

I have not found a workaround.

Is this a regression?

Yes. This used to work, but now it doesn't.

Affected versions

Failing since 1.3.0 works in 1.2.0

Browser/OS/Node environment

Node v.20.14.0
NPM v.10.7.0

@asyncLiz asyncLiz self-assigned this Jun 20, 2024
@asyncLiz
Copy link
Collaborator

Good catch! I'll send out a fix shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment