Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github workflows #38

Merged
merged 2 commits into from
Feb 15, 2024
Merged

update github workflows #38

merged 2 commits into from
Feb 15, 2024

Conversation

mbkma
Copy link
Member

@mbkma mbkma commented Feb 4, 2024

With this, PR previews should actually work.

Copy link

github-actions bot commented Feb 4, 2024

PR Preview Action v1.4.6
🚀 Deployed preview to https://mate-desktop.github.io/mate-wiki/pr-preview/pr-38/
on branch gh-pages at 2024-02-04 22:43 UTC

@mbkma mbkma requested a review from a team February 4, 2024 22:47
@mbkma
Copy link
Member Author

mbkma commented Feb 4, 2024

We can delete https://github.com/mate-desktop/mate-wiki-preview with this PR.

@mbkma
Copy link
Member Author

mbkma commented Feb 12, 2024

If no one likes to review I am going to merge these, as they are not critical and only concern the wiki.

@raveit65
Copy link
Member

raveit65 commented Feb 12, 2024

We got a reviewer problem since years. Everybody needs to review other open reviews, otherwise this system doesn't work.
Still wondering that you ask for a rush review after we didn't hear from you since a year.
Any way, preview is working, go ahead.
I don't have the time and interest to read documents how wiki CMS and github deployment is working.

Copy link
Member

@raveit65 raveit65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview is working

@mbkma mbkma merged commit e169c91 into master Feb 15, 2024
1 check passed
@mbkma mbkma deleted the preview branch February 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants