Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub cache instead of FTP to use OpenDDS artifacts within pull request and Release workflows #43

Merged
merged 13 commits into from
Aug 11, 2023
Merged

Use GitHub cache instead of FTP to use OpenDDS artifacts within pull request and Release workflows #43

merged 13 commits into from
Aug 11, 2023

Conversation

masesdevelopers
Copy link
Contributor

Description

The PR updates workflows to use GitHub cache to store OpenDDS artifacts within Pull Requests and Release.
This speedup both actions because of stored information.
If cache is not available it will be rebuilt before execute the action

Related Issue

Closed #42

Motivation and Context

How Has This Been Tested?

Tested running workflows

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added the enhancement New feature or request label Aug 11, 2023
@masesdevelopers masesdevelopers self-assigned this Aug 11, 2023
mariomastrodicasa
mariomastrodicasa reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mariomastrodicasa mariomastrodicasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up commented code

.github/workflows/build.yaml Show resolved Hide resolved
.github/workflows/build.yaml Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
@masesdevelopers masesdevelopers merged commit 13317e7 into masesgroup:master Aug 11, 2023
3 checks passed
@masesdevelopers masesdevelopers deleted the 42-use-github-cache-instead-of-ftp-site-to-use-opendds-artifacts-within-pull-request-and-release-workflows branch August 11, 2023 18:32
@masesdevelopers masesdevelopers mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariomastrodicasa mariomastrodicasa mariomastrodicasa left review comments

Assignees

@masesdevelopers masesdevelopers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use GitHub cache instead of FTP site to use OpenDDS artifacts within Pull Request and Release workflows
2 participants
@masesdevelopers @mariomastrodicasa