Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve form validation #1304

Merged
merged 1 commit into from
May 18, 2024
Merged

Improve form validation #1304

merged 1 commit into from
May 18, 2024

Conversation

marvinruder
Copy link
Owner

  • Use checkValidity()
  • Show error messages in helper text with onInvalid callback
  • Use number input type and override default browser styling
  • Replace event target value modifiers with validation constraints
  • Remove onMouseOver callbacks

* Use `checkValidity()`
* Show error messages in helper text with `onInvalid` callback
* Use `number` input type and override default browser styling
* Replace event target value modifiers with validation constraints
* Remove `onMouseOver` callbacks

Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
@marvinruder marvinruder added frontend Related to frontend package technical Refactoring, code styling, logging, testing or other technical tasks labels May 18, 2024
@marvinruder marvinruder self-assigned this May 18, 2024
@marvinruder marvinruder linked an issue May 18, 2024 that may be closed by this pull request
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: +0.00%) 100.00% (target: 100.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c49b15f) 10849 10849 100.00%
Head commit (6aafbcc) 10850 (+1) 10850 (+1) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1304) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@marvinruder marvinruder merged commit 7f9f045 into main May 18, 2024
11 checks passed
@marvinruder marvinruder deleted the 800-improve-form-validation branch May 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Related to frontend package technical Refactoring, code styling, logging, testing or other technical tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve form validation
1 participant