Feature/Support several sections like Intro, Solo #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
ChristophWalter
force-pushed
the
feature/support-several-sections
branch
from
7d5c7b3
to
bb82d64
Compare
|
Code Climate has analyzed commit e78c820 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to create a stylesheet for a html formatted song where sections like the song chorus, intro or solo are highlighted. Therefore it is necessary to have a wrapper element for those sections.
This PR will make it possible to use tags like
{start_of_intro}(where intro can be anything) to structure the song.Besides that, it fixed a bug where blank lyric lines are rendered using the html div formatter. Now these lines are not rendered like using the html table or text formatter.