adds support for X-PUBLISHED-TTL property. #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
X-PUBLISHED-TTL
branch
from
a8e3447
to
f1e5cd9
Compare
|
Hey @stopfstedt thanks for your contribution! From the code perspective, the changes are looking good, but the documentation is missing. Can you add some explanatory words to the documentation describing what this property does? |
stopfstedt
force-pushed
the
X-PUBLISHED-TTL
branch
from
f1e5cd9
to
50c179b
Compare
|
Hi @markuspoerschke, I added a new sub-page to the docs, in the Advanced section.
|
stopfstedt
force-pushed
the
X-PUBLISHED-TTL
branch
from
50c179b
to
0452d1b
Compare
markuspoerschke
requested changes
Jun 20, 2022
Co-authored-by: Markus Poerschke <markus@poerschke.nrw>
markuspoerschke
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I'm currently working on upgrading from version
0.16.1and noticed that the ability to set this property did not make it into v2 yet.I'm hereby humbly requesting that this functionality gets added back in, please see attached changes.
Thanks!