Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to use the new mysql::deepmerge function #123

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Porting to use the new mysql::deepmerge function #123

merged 1 commit into from
Nov 5, 2018

Conversation

binford2k
Copy link
Contributor

The mysql_deepmerge function was flawed and will crash on Puppet version 5.5.7. This changes your code to use the new version of the function, which does not have this flaw. See https://tickets.puppetlabs.com/browse/MODULES-8193 for more details.

The `mysql_deepmerge` function was flawed and will crash on Puppet version 5.5.7. This changes your code to use the new version of the function, which does not have this flaw.  See https://tickets.puppetlabs.com/browse/MODULES-8193 for more details.
@binford2k
Copy link
Contributor Author

Btw, you should update your test matrix to match your module's support :)

version_requirement": ">= 4.10.0 < 6.0.0"

@fraenki
Copy link
Member

fraenki commented Nov 1, 2018

@binford2k Thanks! I'll leave this open until there's a release of puppetlabs/mysql that contains this change.

Btw, you should update your test matrix

Thanks. Fixing CI is planned #108.

@fraenki fraenki self-assigned this Nov 1, 2018
@fraenki fraenki added this to the 1.1.0 milestone Nov 1, 2018
@xTrekStorex
Copy link

@fraenki

@binford2k Thanks! I'll leave this open until there's a release of puppetlabs/mysql that contains this change.

Just FYI: That change has been included since puppetlabs/mysql release 6.0.0 - we are on 7.0.0 with 6.2.0 and 6.1.0 as releases in between (https://forge.puppet.com/puppetlabs/mysql/changelog).
This was the PR: puppetlabs/puppetlabs-mysql#1044

@fraenki
Copy link
Member

fraenki commented Nov 5, 2018

@xTrekStorex Thanks for the clarification!

@fraenki fraenki merged commit 4218e25 into markt-de:master Nov 5, 2018
@fraenki fraenki removed the upstream label Nov 5, 2018
@fraenki fraenki modified the milestones: 1.1.0, 1.0.2 Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants