fix: always consume terminator if it is preceded by an operator #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e8463ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DylanPiercey
force-pushed
the
consume-terminator-if-operator
branch
from
94e5c64
to
695cd2b
Compare
DylanPiercey
force-pushed
the
consume-terminator-if-operator
branch
from
695cd2b
to
e8463ff
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 93.66% 93.84% +0.18%
==========================================
Files 27 27
Lines 1294 1300 +6
Branches 293 296 +3
==========================================
+ Hits 1212 1220 +8
+ Misses 53 51 -2
Partials 29 29
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that in the expression state whenever a terminator is found for the expression and the terminator is preceded by an operator that expression state continues.
Motivation and Context
This allows for better parsing of expressions in several places. The case that brought about this change was as follows:
With the above the tag variable state was being terminated by the
(and going into tag arguments / shorthand default method mode. With this change it will now see the paren and walk backward past whitespace to see the:which is an expression operator causing the(B | C)to be a part of the tag variable (for types).Screenshots (if appropriate):
Checklist: