Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure unary expression continuation is a word boundary #156

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

Fix regression where the parser would continue unary keyword expressions even if the keyword was inside a word boundary. Eg <div class=thing_new x> would cause the parser to see the expression as thing_ and new x.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2023

🦋 Changeset detected

Latest commit: 73eb906

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (785a593) 93.43% compared to head (73eb906) 93.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          26       26           
  Lines        1279     1280    +1     
  Branches      291      291           
=======================================
+ Hits         1195     1196    +1     
  Misses         54       54           
  Partials       30       30           
Impacted Files Coverage Δ
src/states/EXPRESSION.ts 93.54% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 72b3379 into main Mar 11, 2023
@DylanPiercey DylanPiercey deleted the ensure-unary-not-in-word branch March 11, 2023 22:03
@github-actions github-actions bot mentioned this pull request Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant