Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tag variable not terminated on concise mode text delimiter #150

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

The following would cause the parser to see the - after the tag var as an expression continuation instead of beginning a concise text block.

style/style --
  header {
    color: green
  }

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2023

🦋 Changeset detected

Latest commit: 138b1c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
htmljs-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 92.70% // Head: 93.41% // Increases project coverage by +0.70% 🎉

Coverage data is based on head (138b1c4) compared to base (cfa3483).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   92.70%   93.41%   +0.70%     
==========================================
  Files          26       26              
  Lines        1262     1276      +14     
  Branches      268      289      +21     
==========================================
+ Hits         1170     1192      +22     
+ Misses         58       53       -5     
+ Partials       34       31       -3     
Impacted Files Coverage Δ
src/states/OPEN_TAG.ts 90.95% <100.00%> (+3.08%) ⬆️
src/states/JS_COMMENT_LINE.ts 77.77% <0.00%> (-9.73%) ⬇️
src/states/CONCISE_HTML_CONTENT.ts 89.23% <0.00%> (-2.84%) ⬇️
src/states/HTML_CONTENT.ts 91.89% <0.00%> (-2.48%) ⬇️
src/states/TAG_NAME.ts 98.24% <0.00%> (+0.03%) ⬆️
src/core/Parser.ts 93.47% <0.00%> (+0.77%) ⬆️
src/states/ATTRIBUTE.ts 95.20% <0.00%> (+1.45%) ⬆️
src/states/PLACEHOLDER.ts 97.61% <0.00%> (+2.38%) ⬆️
src/states/CLOSE_TAG.ts 93.33% <0.00%> (+4.44%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 0d7210b into main Feb 13, 2023
@DylanPiercey DylanPiercey deleted the tag-var-concise-text branch February 13, 2023 19:05
@github-actions github-actions bot mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant