E2E test for Unhealthy GameServer on process crash

Also moves udp-simple from 0.14=>0.15 More preparation for googleforgames#956
markmandel · Sep 5, 2019 · 963e6d3 · 963e6d3
1 parent acaccf0
commit 963e6d3
Show file tree

Hide file tree

Showing 17 changed files with 41 additions and 20 deletions.
diff --git a/build/Makefile b/build/Makefile
@@ -57,7 +57,7 @@ KIND_PROFILE ?= agones
 KIND_CONTAINER_NAME=$(KIND_PROFILE)-control-plane
 
 # Game Server image to use while doing end-to-end tests
-GS_TEST_IMAGE ?= gcr.io/agones-images/udp-server:0.14
+GS_TEST_IMAGE ?= gcr.io/agones-images/udp-server:0.15
 
 # Directory that this Makefile is in.
 mkfile_path := $(abspath $(lastword $(MAKEFILE_LIST)))

diff --git a/examples/fleet.yaml b/examples/fleet.yaml
@@ -67,4 +67,4 @@ spec:
         spec:
           containers:
           - name: simple-udp
-            image: gcr.io/agones-images/udp-server:0.14
+            image: gcr.io/agones-images/udp-server:0.15
diff --git a/examples/gameserver.yaml b/examples/gameserver.yaml
@@ -71,5 +71,5 @@ spec:
     spec:
       containers:
       - name: simple-udp
-        image:  gcr.io/agones-images/udp-server:0.14
+        image:  gcr.io/agones-images/udp-server:0.15
         imagePullPolicy: Always
diff --git a/examples/simple-udp/dev-gameserver.yaml b/examples/simple-udp/dev-gameserver.yaml
@@ -31,4 +31,4 @@ spec:
     spec:
       containers:
       - name: simple-udp
-        image: gcr.io/agones-images/udp-server:0.14
+        image: gcr.io/agones-images/udp-server:0.15
diff --git a/examples/simple-udp/fleet-distributed.yaml b/examples/simple-udp/fleet-distributed.yaml
@@ -32,7 +32,7 @@ spec:
         spec:
           containers:
           - name: simple-udp
-            image: gcr.io/agones-images/udp-server:0.14
+            image: gcr.io/agones-images/udp-server:0.15
             resources:
               requests:
                 memory: "32Mi"

diff --git a/examples/simple-udp/fleet.yaml b/examples/simple-udp/fleet.yaml
@@ -27,7 +27,7 @@ spec:
         spec:
           containers:
           - name: simple-udp
-            image: gcr.io/agones-images/udp-server:0.14
+            image: gcr.io/agones-images/udp-server:0.15
             resources:
               requests:
                 memory: "64Mi"

diff --git a/examples/simple-udp/gameserver-passthrough.yaml b/examples/simple-udp/gameserver-passthrough.yaml
@@ -24,7 +24,7 @@ spec:
     spec:
       containers:
       - name: simple-udp
-        image: gcr.io/agones-images/udp-server:0.14
+        image: gcr.io/agones-images/udp-server:0.15
         env:
           - name: "PASSTHROUGH"
             value: "TRUE"

diff --git a/examples/simple-udp/gameserver.yaml b/examples/simple-udp/gameserver.yaml
@@ -25,7 +25,7 @@ spec:
     spec:
       containers:
       - name: simple-udp
-        image: gcr.io/agones-images/udp-server:0.14
+        image: gcr.io/agones-images/udp-server:0.15
         resources:
           requests:
             memory: "32Mi"

diff --git a/examples/simple-udp/gameserverset.yaml b/examples/simple-udp/gameserverset.yaml
@@ -31,4 +31,4 @@ spec:
         spec:
           containers:
           - name: simple-udp
-            image: gcr.io/agones-images/udp-server:0.14
+            image: gcr.io/agones-images/udp-server:0.15
diff --git a/pkg/util/webhooks/webhooks_test.go b/pkg/util/webhooks/webhooks_test.go
@@ -163,7 +163,7 @@ func TestWebHookFleetValidationHandler(t *testing.T) {
 							"template": {
 								"spec": {
 									"containers": [{
-										"image": "gcr.io/agones-images/udp-server:0.14",
+										"image": "gcr.io/agones-images/udp-server:0.15",
 										"name": false
 									}]
 								}

diff --git a/site/config.toml b/site/config.toml
@@ -91,7 +91,7 @@ release_branch = "release-0.12.0"
 release_version = "0.12.0"
 
 # example tag
-example_image_tag = "gcr.io/agones-images/udp-server:0.14"
+example_image_tag = "gcr.io/agones-images/udp-server:0.15"
 
 # User interface configuration
 [params.ui]

diff --git a/site/content/en/docs/Guides/local-game-server.md b/site/content/en/docs/Guides/local-game-server.md
@@ -32,7 +32,7 @@ spec:
     spec:
       containers:
       - name: simple-udp
-        image: gcr.io/agones-images/udp-server:0.14
+        image: gcr.io/agones-images/udp-server:0.15
 ```
 
 Once you save this to a file make sure you have `kubectl` configured to point to your Agones cluster and then run `kubectl apply -f dev-gameserver.yaml`. This will register your server with Agones.

diff --git a/site/content/en/docs/Guides/troubleshooting.md b/site/content/en/docs/Guides/troubleshooting.md
@@ -51,7 +51,7 @@ Spec:
       Creation Timestamp:  <nil>
     Spec:
       Containers:
-        Image:  gcr.io/agones-images/udp-server:0.14
+        Image:  gcr.io/agones-images/udp-server:0.15
         Name:   simple-udp
         Resources:
           Limits:
@@ -82,7 +82,7 @@ Events:
 The backing Pod has the same name as the `GameServer` - so it's also worth looking at the
 details and events for the Pod to see if there are any issues there, such as restarts due to binary crashes etc.
 
-For example, you can see the restart count on the gcr.io/agones-images/udp-server:0.14 container
+For example, you can see the restart count on the gcr.io/agones-images/udp-server:0.15 container
 is set to `1`, due to the game server binary crash
 
 ```
@@ -104,7 +104,7 @@ Controlled By:      GameServer/simple-udp-zqppv
 Containers:
   simple-udp:
     Container ID:   docker://69eacd03cc89b0636b78abe47926b02183ba84d18fa20649ca443f5232511661
-    Image:          gcr.io/agones-images/udp-server:0.14
+    Image:          gcr.io/agones-images/udp-server:0.15
     Image ID:       docker-pullable://gcr.io/agones-images/udp-server@sha256:6a60eff5e68b88b5ce75ae98082d79cff36cda411a090f3495760e5c3b6c3575
     Port:           7654/UDP
     Host Port:      7058/UDP
@@ -173,7 +173,7 @@ Events:
   Normal  Created    2m28s                 kubelet, gke-test-cluster-default-590db5e4-4s6r  Created container
   Normal  Created    114s (x2 over 2m31s)  kubelet, gke-test-cluster-default-590db5e4-4s6r  Created container
   Normal  Started    114s (x2 over 2m31s)  kubelet, gke-test-cluster-default-590db5e4-4s6r  Started container
-  Normal  Pulled     114s (x2 over 2m31s)  kubelet, gke-test-cluster-default-590db5e4-4s6r  Container image "gcr.io/agones-images/udp-server:0.14" already present on machine
+  Normal  Pulled     114s (x2 over 2m31s)  kubelet, gke-test-cluster-default-590db5e4-4s6r  Container image "gcr.io/agones-images/udp-server:0.15" already present on machine
 ```
 
 Finally, you can also get the logs of your `GameServer` `Pod` as well via `kubectl logs <pod name> -c <game server container name>`, for example:

diff --git a/site/content/en/docs/Reference/fleet.md b/site/content/en/docs/Reference/fleet.md
@@ -62,7 +62,7 @@ spec:
         spec:
           containers:
           - name: simple-udp
-            image: gcr.io/agones-images/udp-server:0.14
+            image: gcr.io/agones-images/udp-server:0.15
 ```
 
 Since Agones defines a new 

diff --git a/site/content/en/docs/Reference/gameserver.md b/site/content/en/docs/Reference/gameserver.md
@@ -60,7 +60,7 @@ spec:
     spec:
       containers:
       - name: simple-udp
-        image:  gcr.io/agones-images/udp-server:0.14
+        image:  gcr.io/agones-images/udp-server:0.15
         imagePullPolicy: Always
 ```
 

diff --git a/test/e2e/gameserver_test.go b/test/e2e/gameserver_test.go
@@ -211,6 +211,27 @@ func TestGameServerUnhealthyAfterDeletingPod(t *testing.T) {
 	assert.NoError(t, err)
 }
 
+func TestGameServerUnhealthyAfterReadyCrash(t *testing.T) {
+	t.Parallel()
+	gs := defaultGameServer()
+	readyGs, err := framework.CreateGameServerAndWaitUntilReady(defaultNs, gs)
+	if err != nil {
+		t.Fatalf("Could not get a GameServer ready: %v", err)
+	}
+
+	gsClient := framework.AgonesClient.AgonesV1().GameServers(defaultNs)
+	defer gsClient.Delete(readyGs.ObjectMeta.Name, nil) // nolint: errcheck
+
+	// there is no response, so don't wait for the timeout
+	go func() {
+		// ignore the error, we don't care about the response
+		e2eframework.SendGameServerUDP(readyGs, "CRASH") // nolint: errcheck
+	}()
+
+	_, err = framework.WaitForGameServerState(readyGs, agonesv1.GameServerStateUnhealthy, 3*time.Minute)
+	assert.NoError(t, err)
+}
+
 func TestDevelopmentGameServerLifecycle(t *testing.T) {
 	t.Parallel()
 	gs := &agonesv1.GameServer{

diff --git a/test/e2e/main_test.go b/test/e2e/main_test.go
@@ -34,8 +34,8 @@ func TestMain(m *testing.M) {
 	usr, _ := user.Current()
 	kubeconfig := flag.String("kubeconfig", filepath.Join(usr.HomeDir, "/.kube/config"),
 		"kube config path, e.g. $HOME/.kube/config")
-	gsimage := flag.String("gameserver-image", "gcr.io/agones-images/udp-server:0.14",
-		"gameserver image to use for those tests, gcr.io/agones-images/udp-server:0.14")
+	gsimage := flag.String("gameserver-image", "gcr.io/agones-images/udp-server:0.15",
+		"gameserver image to use for those tests, gcr.io/agones-images/udp-server:0.15")
 	pullSecret := flag.String("pullsecret", "",
 		"optional secret to be used for pulling the gameserver and/or Agones SDK sidecar images")
 	stressTestLevel := flag.Int("stress", 0, "enable stress test at given level 0-100")