Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use named exports only for ESM build #2226

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

benmccann
Copy link
Contributor

Marked version: 3.0.6

Markdown flavor: all

Description

Expectation

UMD build should have only default export for backwards compatibility. CJS cannot have both named and default exports like ESM can

Result

Backwards compatibility broke in UMD build

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Oct 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/7hqcLD8XkkvDd67KoNgefVcPbU9B
✅ Preview: https://markedjs-git-fork-benmccann-esm-entry-markedjs.vercel.app

Copy link
Member

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@benmccann
Copy link
Contributor Author

No problem. Sorry I broke things

@UziTech
Copy link
Member

UziTech commented Oct 7, 2021

Happens to all of us ☺️

@ddolcimascolo
Copy link

Hi guys, do you plan to release a patched version soon?

Thx,
David

@styfle styfle merged commit 223e61d into markedjs:master Oct 7, 2021
@RomanHotsiy
Copy link
Contributor

RomanHotsiy commented Oct 7, 2021

@UziTech @styfle could you please cut a new release 🙏. This breaks our customer builds.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

🎉 This PR is included in version 3.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ddolcimascolo
Copy link

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants