Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint all the things #1185

Merged
merged 4 commits into from
Apr 4, 2018
Merged

Eslint all the things #1185

merged 4 commits into from
Apr 4, 2018

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 29, 2018

Marked version: 8489411

Description

  • eslint will lint all .js files except /marked.min.js and it will lint /bin/marked

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@joshbruce
Copy link
Member

Thought we decided to ignore test. No skin in this game for me, just making sure not missing some rationale.

@UziTech
Copy link
Member Author

UziTech commented Mar 29, 2018

no, /test/index.js was being linted. I just forgot to update the eslint calls when I added Jasmine

bin/marked Outdated
.on('error', function(err) {
fs.readFile(__dirname + '/../man/marked.1.txt', 'utf8', function(err, data) {
spawn('man', [path.resolve(__dirname, '/../man/marked.1')], options)
.on('error', function(err) { // eslint-disable-line handle-callback-err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this err be removed since it is unused rather than disabled eslint here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

@joshbruce joshbruce mentioned this pull request Apr 4, 2018
6 tasks
@UziTech UziTech requested a review from joshbruce April 4, 2018 18:23
Copy link
Member

@joshbruce joshbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna want to run this over my latest additions. lol

@joshbruce joshbruce merged commit 3f6b2c8 into markedjs:master Apr 4, 2018
@UziTech UziTech deleted the eslint-all-the-things branch April 5, 2018 14:39
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants