Update SSSOM Extended Prefix Map #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
matentzn
approved these changes
Dec 4, 2023
| @@ -5567,6 +6413,9 @@ | |||
| { | |||
| "pattern": "^\\d+$", | |||
| "prefix": "VariO", | |||
| "prefix_synonyms": [ | |||
| "vario" | |||
There was a problem hiding this comment.
@cthoyt not that with a similar logic you could have added VARIO as a prefix as well - I guess you know but want to move the world closer to lower case prefixes.
There was a problem hiding this comment.
The Bioregistry canonical prefixes are lower, this just adds those. A more generic adding of lower/upper is going in biopragmatics/bioregistry#969, but there are awful OBO corner case I have't figured out in general yet
| @@ -685,6 +803,9 @@ | |||
| { | |||
| "pattern": "^\\d{7}$", | |||
| "prefix": "CO_320", | |||
| "prefix_synonyms": [ | |||
| "co_320" | |||
There was a problem hiding this comment.
@cthoyt note the underscores are still here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates sssom extended prefix map (epm). Make sure you run make tests manually.