Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant documentation #904

Closed
wants to merge 1 commit into from
Closed

Conversation

wipfli
Copy link
Member

@wipfli wipfli commented Jan 27, 2022

Launch Checklist

After the migration to TypeScript #209, the documentation can be simplified. Function argument types can be take directly from the TypeScript source code.

This pull request removes redundant type annotations. The output documentation website stays unchanged.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Manually test the debug page.
  • Suggest a changelog category: bug/feature/docs/etc. or "skip changelog".
  • Add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>.

@wipfli
Copy link
Member Author

wipfli commented Jan 27, 2022

#891

@github-actions
Copy link
Contributor

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 184 kB 184 kB 0 B
maplibre-gl.css 9.5 kB 9.5 kB 0 B
ℹ️ View Details No major changes

@wipfli wipfli closed this Feb 3, 2022
@wipfli wipfli deleted the remove-redundant-type-docs branch February 3, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant