Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on removal of mapbox:// protocol #770

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

wipfli
Copy link
Member

@wipfli wipfli commented Jan 13, 2022

Launch Checklist

This pull request updates jsdocs comments on the removal of the mapbox:// protocol, which happened in the TypeScript migration #209.

The style specification is updated too, to reflect the removal of mapbox:// and its major version is bumped from 14 to 15.

Since I was cleaning up the docs, I also replaced Mapbox with MapLibre and removed links to mapbox.com.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Manually test the debug page.
  • Suggest a changelog category: bug/feature/docs/etc. or "skip changelog".
  • Add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>.

@github-actions
Copy link
Contributor

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 185 kB 185 kB 0 B
maplibre-gl.css 9.49 kB 9.49 kB 0 B
ℹ️ View Details No major changes

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@HarelM
Copy link
Collaborator

HarelM commented Jan 13, 2022

Also related to #27

@HarelM HarelM merged commit 5de24d1 into maplibre:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants