Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jest] Migrate dblclick_zoom.test.js #697

Merged
merged 5 commits into from
Dec 7, 2021

Conversation

wipfli
Copy link
Member

@wipfli wipfli commented Dec 3, 2021

  • Move and rename
  • Run jscodeshift
  • Run custom codemods and lint
  • Manual edits

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Manually test the debug page.
  • Suggest a changelog category: bug/feature/docs/etc. or "skip changelog".
  • Add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 185 kB 185 kB 0 B
maplibre-gl.css 9.49 kB 9.49 kB 0 B
ℹ️ View Details No major changes

@wipfli wipfli marked this pull request as ready for review December 7, 2021 19:43
@wipfli
Copy link
Member Author

wipfli commented Dec 7, 2021

@HarelM this one is ready as well.

@HarelM
Copy link
Collaborator

HarelM commented Dec 7, 2021

I'm assuming wrap in describe is not changing any thing besides wrapping in describe, if this is not the case make sure to comment the commit differently.

@wipfli
Copy link
Member Author

wipfli commented Dec 7, 2021

I'm assuming wrap in describe is not changing any thing besides wrapping in describe, if this is not the case make sure to comment the commit differently.

It is the case. Wrap in describe is only wrapping all tests in a describe function.

@wipfli wipfli merged commit 41c3b10 into maplibre:main Dec 7, 2021
@wipfli wipfli deleted the dblclick_zoom.test.js branch December 7, 2021 19:54
davenquinn added a commit to davenquinn/maplibre-gl-js that referenced this pull request Dec 29, 2021
* main: (98 commits)
  [Jest] Migrate `geojson_worker_source.test.js` (maplibre#731)
  Fix events being fired after Map#remove has been called when the WebGL context is lost and restored (maplibre#726) (maplibre#727)
  Define return type of getSource as possibly undefined (maplibre#724)
  Fix attibution controll (maplibre#668)
  Fix start-debug to watch ts files (maplibre#704)
  [Jest] Migrate `touch_zoom_rotate.test.js` (maplibre#721)
  [Jest] Migrate `requestRenderFrame.test.js` (maplibre#722)
  [Jest] Migrate `scroll_zoom.test.js` (maplibre#712)
  [Jest] Migrate `marker.test.js` (maplibre#696)
  [Jest] Migrate `mouse_rotate.test.js` (maplibre#711)
  [Jest] Migrate `keyboard.test.js` (maplibre#707)
  [Jest] Migrate `map_event.test.js` (maplibre#710)
  [Jest] Migrate `drag_rotate.test.js` (maplibre#709)
  Handle spies and call counts (maplibre#708)
  [Jest] Migrate `drag_pan.test.js` (maplibre#702)
  Add type for styleimagemissing event (maplibre#703)
  Fix MapDataEvent#isSourceLoaded being true in GeoJSONSource "dataloading" event handlers (maplibre#694) (maplibre#695)
  [Jest] Migrate `dblclick_zoom.test.js` (maplibre#697)
  [Jest] Migrate `popup.test.js` (maplibre#687)
  Fixed typo (maplibre#698)
  ...
@birkskyum birkskyum added this to the Transition from Tap to Jest milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants