Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4268 fix async race when adding/removing geolocate rapidly #4454

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

nkundu
Copy link
Contributor

@nkundu nkundu commented Jul 25, 2024

Attempt to fix #4268 via the suggested method of initially creating the icon in the disabled state, then updating it to active in the callback.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (c0f1936) to head (4265456).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4454      +/-   ##
==========================================
- Coverage   87.79%   87.73%   -0.06%     
==========================================
  Files         246      246              
  Lines       33404    33412       +8     
  Branches     2184     2223      +39     
==========================================
- Hits        29327    29314      -13     
+ Misses       3088     3077      -11     
- Partials      989     1021      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkundu nkundu marked this pull request as ready for review July 29, 2024 13:22
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!

@HarelM HarelM enabled auto-merge (squash) July 29, 2024 20:07
@HarelM HarelM merged commit 43cbe50 into maplibre:main Jul 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeolocateControl create control button twice when mounted/unmounted/remounted
3 participants