Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4375 remove hash string when hash remove #4427

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Conversation

smellman
Copy link
Contributor

@smellman smellman commented Jul 18, 2024

Fixes #4375

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

https://i.gyazo.com/d78de26968289b6814e4852fbf913175.gif

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.79%. Comparing base (3c5edcf) to head (cecec23).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4427      +/-   ##
==========================================
+ Coverage   87.65%   87.79%   +0.13%     
==========================================
  Files         246      246              
  Lines       33375    33396      +21     
  Branches     2185     2192       +7     
==========================================
+ Hits        29255    29319      +64     
+ Misses       3123     3071      -52     
- Partials      997     1006       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ui/hash.ts Outdated Show resolved Hide resolved
src/ui/hash.ts Outdated Show resolved Hide resolved
@HarelM
Copy link
Collaborator

HarelM commented Jul 18, 2024

Thanks for taking the time to open this PR!
Please make sure to add a test to cover this scenario.

@smellman smellman marked this pull request as ready for review July 18, 2024 13:56
@smellman
Copy link
Contributor Author

@HarelM I added some test cases and fixes codes.
Please review current code.

src/ui/hash.ts Show resolved Hide resolved
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@HarelM HarelM merged commit 7ef01a7 into maplibre:main Jul 19, 2024
15 checks passed
@birkskyum birkskyum mentioned this pull request Sep 20, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The map still adds the hash after calling map.remove()
3 participants