-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure loseContext
exists before calling it
#4245
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4245 +/- ##
==========================================
- Coverage 87.73% 87.37% -0.36%
==========================================
Files 242 242
Lines 33081 33081
Branches 2160 2173 +13
==========================================
- Hits 29023 28906 -117
- Misses 3088 3182 +94
- Partials 970 993 +23 ☔ View full report in Codecov by Sentry. |
Can you add a changelog entry like this: in the bugfix section here: Line 20 in 760f9d1
|
Co-authored-by: Harel M <harel.mazor@gmail.com>
@birkskyum Similar fix was necessary to get
plotly.js
working withvirtual-webgl
(v1).See plotly/mapbox-gl-js@71e2cfc
This is for your brilliant pull request plotly/plotly.js#7015
if you could possibly test a build with
make-baselines-virtual-webgl
to see if it passes on CircleCIor alternatively add the following script to the top of plotly.js
devtools/test_dashboard/index.js
and thennpm start
to test interactively.Launch Checklist
CHANGELOG.md
under the## main
section.