Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md with node upgrade #3455

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Update CHANGELOG.md with node upgrade #3455

merged 4 commits into from
Dec 7, 2023

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Dec 6, 2023

In continue to #3452, where I forgot to add this...

@HarelM HarelM requested a review from louwers December 6, 2023 10:48
@HarelM HarelM enabled auto-merge (squash) December 6, 2023 10:49
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e45696) 74.74% compared to head (76b45c4) 74.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3455   +/-   ##
=======================================
  Coverage   74.74%   74.74%           
=======================================
  Files         242      242           
  Lines       19146    19146           
  Branches     4240     4240           
=======================================
  Hits        14311    14311           
  Misses       4835     4835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really relevant for end-users?

@HarelM
Copy link
Collaborator Author

HarelM commented Dec 6, 2023

No, more for developers and for me to know when things changed so I can backtrack issues without looking at the git history which is filled with dependencies updates.

@HarelM
Copy link
Collaborator Author

HarelM commented Dec 7, 2023

@louwers let me know if you want me to remove this changelog comment or not, I don't have strong feelings either way.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK, sure. Maybe a new category for this makes sense, since probably a lot more users that are not developers read the changelog?

@HarelM HarelM merged commit f0028c9 into main Dec 7, 2023
14 checks passed
@HarelM HarelM deleted the update-changelog branch December 7, 2023 11:49
@HarelM
Copy link
Collaborator Author

HarelM commented Dec 7, 2023

IDK who really reads these changelogs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants