Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad merge, bump version to 1.15.1 #195

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Fix bad merge, bump version to 1.15.1 #195

merged 2 commits into from
Jul 7, 2021

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jul 6, 2021

Launch Checklist

Fix bad css merge, update changelog, prepare to release 1.15.1

  • confirm your changes do not include backports from Mapbox projects (unless with compliant license)
  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Bundle size report:

Size Change: -7 B
Total Size Before: 205 kB
Total Size After: 205 kB

Output file Before After Change
maplibre-gl.js 196 kB 196 kB -7 B
maplibre-gl.css 8.87 kB 8.87 kB 0 B
ℹ️ View Details
Source file Before After Change
src/util/mapbox.js 3.06 kB 3.06 kB -1 B
src/ui/map.js 6.27 kB 6.26 kB -6 B

@HarelM
Copy link
Collaborator Author

HarelM commented Jul 7, 2021

@curran @thaddmt @Malvoz @roblabs Any chance one of you can review this? there's not much here...

Copy link
Member

@wipfli wipfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wipfli
Copy link
Member

wipfli commented Jul 7, 2021

The additional changelog message is probably due to forgetting it earlier, right?

@HarelM
Copy link
Collaborator Author

HarelM commented Jul 7, 2021

I don't know what happen when I edited the change log. I have updated it now...

@HarelM HarelM merged commit b23ebea into main Jul 7, 2021
@HarelM HarelM deleted the fix-css-merge branch July 7, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants