Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove elevationOffset and fix below sea-level clipping #1578

Merged
merged 8 commits into from
Sep 16, 2022
Merged

Remove elevationOffset and fix below sea-level clipping #1578

merged 8 commits into from
Sep 16, 2022

Commits on Aug 29, 2022

  1. Remove elevationOffset and add far plane min value of 4000 instead

    @birkskyum
    birkskyum committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    18af619 View commit details
    Browse the repository at this point in the history

  2. remove elevationOffset

    @birkskyum
    birkskyum committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    7d7a1cb View commit details
    Browse the repository at this point in the history

  3. fix unit tests

    @birkskyum
    birkskyum committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b0831e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Fix clipping of areas below sea level

    @birkskyum
    birkskyum committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    70909b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Remove hardcoded numbers and make sure everything is working as expec… 

    …ted.
    @HarelM
    HarelM committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    8eefb8d View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @HarelM
    HarelM committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    58cc7bb View commit details
    Browse the repository at this point in the history

  3. Improve code readability even more.

    @HarelM
    HarelM committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    4d12c17 View commit details
    Browse the repository at this point in the history

  4. test zoomcalculation for elevation below sea level

    @birkskyum
    birkskyum committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    d084843 View commit details
    Browse the repository at this point in the history